Backup Remote Files: Treat mounted files also as remote files

Review Request #127805 - Created May 1, 2016 and submitted

Information
Dominik Haumann
ktexteditor
362288
Reviewers
kate, kdeframeworks
cullmann

When backup-remote-files is enabled, QUrl::isLocalFile() is used. However, isLocalFile() also returns true for files that are locally mounted (e.g. nfs, sshfs, ...).

This patch uses KMountPoint::probablySlow() such that mounted remote files are also treated as "true" remote files.

However, KMountPoint::probablySlow() right now only checks the filesystem for nfs, cifs, autofs, or subfs, see:
http://api.kde.org/frameworks-api/apidox-frameworks/frameworks5-apidocs/kio/html/kmountpoint_8cpp_source.html#l00535

So in addition to this patch, we may need to extend KMountPoint::probablySlow() to also return true for e.g. sshfs or similar common remote filessytems.

When reviewing the patch, please note, that katedocument.cpp also still often uses QUrl::isLocalFile(). These usages are still correct, afaics.

Compiles.

Issues

  • 1
  • 0
  • 0
  • 1
Description From Last Updated
Maybe it would make sense to see what's the performance impact of this call KMountPoint::currentMountPoints(). It's potentially slow and it ... Aleix Pol Gonzalez Aleix Pol Gonzalez
Aleix Pol Gonzalez
Dominik Haumann
Review request changed

Status: Closed (submitted)

Change Summary:

Submitted with commit 0da25aabbfbb9595c8d6f047027023770ff7eef3 by Christoph Cullmann to branch master.
Loading...