Don't open kdeglobals explicitly in font/hint settings.

Review Request #127780 - Created April 28, 2016 and submitted

Information
David Edmundson
plasma-integration
master
6b01753...
Reviewers
plasma

The app config (KSharedConfig::openConfig()) is a mix of the app's settings and kdeglobals.

Loading kdeglobals directly not only is a waste of resources, but breaks
one of the key features of KConfig where a user can override global settings
on a per app basis.

What's worse is that KColorScheme when used directly does use the app config, so some apps give an inconsistent mix of results if you try and override settings.


  

Issues

  • 2
  • 0
  • 0
  • 2
Description From Last Updated
Please pull, the code doesn't fit the current state in master. Martin Flöser Martin Flöser
Why's that new line? ;) Aleix Pol Gonzalez Aleix Pol Gonzalez
Marco Martin
Aleix Pol Gonzalez
Martin Flöser
David Edmundson
Aleix Pol Gonzalez
Martin Flöser
David Edmundson
Review request changed

Status: Closed (submitted)

Change Summary:

Submitted with commit b1d8e32b7bae92ddbdee75425576a8d2f8ca41ba by David Edmundson to branch master.
Loading...