really fix include issues, fix FTBFS against qt-5.6.x

Review Request #127608 - Created April 7, 2016 and submitted

Information
Rex Dieter
phonon
4.8
Reviewers
phonon
dvratil, hrvojes, sitter

Previous attempts to fixing include issues ends up throwing away all but the first include dir (and so include dir ordering can make success/failure non-deterministic). As a bonus, add LINK_LIBRARIES "${Qt5Core_LIBRARIES}" in visibility test (else it always fails due to new symbol versioning feature in qt-5.6).

Sorry, this is technically fixing 2 things at once, so I can split it into separate submissions if you prefer.

build succeeds trying to build phonon-qt5 only on rhel7 (previously always fails).

Issues

  • 0
  • 0
  • 1
  • 1
Description From Last Updated
Rex Dieter
Harald Sitter
Hrvoje Senjan
Rex Dieter
Review request changed

Status: Closed (submitted)

Change Summary:

Submitted with commit 203f62201210b5b4cbb63003c8640d7b4810e4fe by Rex Dieter to branch 4.8.
Loading...