[kstyle] Implement window shadows on Wayland
Review Request #127352 - Created March 12, 2016 and submitted
Integrate with Wayland and create a ShadowManager if available. With the ShadowManager it's possible to create a Shadow for a Surface. The Wayland shadow is very similar to the X11 based one, so a lot of code can be shared. The code is slightly refactored to share the common code paths to create and destroy the shadow.
|I thought the policy in case of "external" dependencies, was to include the header rather than using forward declarations. (in ...||Hugo Pereira Da Costa|
couple of nitpicking (which I cand easily fix myself in case you are busy elsewhere.
asside from that, I could not test because have no working wayland setup here (too old distro/drivers), so I'll just trust you.
other than that, good to go imho.
(and don't hesitate to also push to oxygen, if you have time, and without a review. Note that I can do it myself too -without testing-, otherwise)
I thought the policy in case of "external" dependencies, was to include the header rather than using forward declarations. (in case for instance a class is turned into a struct, a namespace into a class, or whatever).
At least have been doing so with Qt since forever.
If not, please add some indentation here after the braces)
some comments before the new methods ?
other class members start with "" rather than "m"
please keep it internally consistent (even if not with the rest of e.g. kwin)
please keep "//_______" (the number of "_" being unimportant) before the beginning of each function, for consistency with the rest of the class.
(and elsewhere in case I missed some)