Compilation fixes for MSVC (2013)

Review Request #127177 - Created Feb. 25, 2016 and submitted

Information
Thomas Friedrichsmeier
ki18n
Reviewers
kdeframeworks, kdewin

Fix compilation on Windows with MSVC.

a) MSVC accepts declspec at global scope, only.
b) QStringLiteral does not work with concatenated literals in MSVC (see http://blog.qt.io/blog/2014/06/13/qt-weekly-13-qstringliteral/). Since the occurences seem to be mostly for debugging, going through QString::fromLatin1() in these cases should not hurt much.

Now builds with MSVC 2013.

No other compilers and no other platforms tested for this patch.

Issues

  • 0
  • 1
  • 0
  • 1
Description From Last Updated
Kevin Funk
Thomas Friedrichsmeier
Thomas Friedrichsmeier
Review request changed

Status: Closed (submitted)

Change Summary:

Submitted with commit 1c2aa25fb179fe3350bee166f2d8e69404d0cc7f by Thomas Friedrichsmeier to branch master.
Loading...