Connect to backend signals to catch cache reload.

Reviews
Diff

- Download Diff

Information
Submitter:	Carlo Vanini
Repository:	muon
Branch:	master
Bugs:	332530
Depends On:	~~127080~~
Commit:	7660dc9...
Reviewers
Groups:	kubuntu, muon
People:

Description

When the cache is reloaded libqapt deletes Package objects and creates them anew. This results in dangling pointers in muon models.

When "Preview Changes" is shown we have two models with lists of packages, and both should be cleared and repopulated.

The cache reload can be triggered by pinning/unpinning (lock/unlock) a package.

Testing Done


mark a package for install/remove
click on "Preview Changes"
right-click on a package and select "Lock at Current Version"

Without patch: clicking on "Back" crashes muon

With patch: no crash, but as a side effect all changes to packages are lost when the cache is reloaded.

Issues

0
1
1
All Issues: 2

Description	From	Last Updated
Maybe you can leave the setSourceModel call after the calling for sortPackages.	Aleix Pol Gonzalez	Feb. 19, 2016, 12:26 a.m.
Why is startSearch() needed now?	Aleix Pol Gonzalez	Feb. 22, 2016, 11:34 p.m.

Other than that, and from my ignorance on the code-base looks good.

(also implicit +1 on the other patch in libqapt).

Carlo Vanini March 3, 2016, 12:39 a.m.
```
Can I ship them?
```

src/PackageModel/PackageWidget.cpp (Diff revision 1)

Show all issues

Maybe you can leave the setSourceModel call after the calling for sortPackages.

src/PackageModel/PackageWidget.cpp (Diff revision 1)

Show all issues

Why is startSearch() needed now?

Carlo Vanini Feb. 19, 2016, 1:05 a.m.

m_proxyModel->reset() removes the packages from the model, but it also invalidates the filter.

Since the search box keeps its value a call to startSearch() restores the same filter.

Section filters (package status, category, ...) are already preserved.

Commit:

-	b2e6fb72c845cd58f12d9416ac946407d1a0a135
+	7660dc978f14b8c6456fd07be2371dbb70ef4a74

Diff:

Revision 2 (+19 -1)

Show changes

	src/MainWindow.cpp
	src/StatusWidget.cpp
	src/PackageModel/PackageWidget.h
	src/PackageModel/PackageWidget.cpp

Ship it!

Status: Closed (submitted)

Change Summary:

Submitted with commit a437d39e43112a3e61ebafadd4e3a06b9bd91437 by Carlo Vanini to branch master.

You have a pending review.

Review Board 2.5.15

Screenshots

Files

Issues

Commit:

Diff:

Status: Closed (submitted)

Change Summary: