ry more aggressively to retarget
Review Request #127101 - Created Feb. 17, 2016 and submitted
instead of deleting all animations when one is over, try to retarget them all, and redo them only if retargeting fails
|something fishy here: for how it behaves, it returned true in every single case, no matter what retarget used to ...||Marco Martin|
|newVariant(bool) was interpreted as always true by qtscript||Marco Martin|
|Wow, I just cnp'd this, so it's wrong everywhere? Got to check.||Thomas Lübking|
Imo the double check isn't required, but in the present state a failing 2nd retarget would lead to a running 1st retarget animation plus the new (first) animation, ie. the animations would have to be cancelled on partial retargetting failure
can be directly re-assigned.
The present code is wrong indeed.
The question is on what to return if only some animations could be retargetted (list handing question in general)
Either we &= from "ok == true" (one failure causes a false return) or we |= from "ok == false" (any success causes a true return)
Probably both is wrong and the better solution is to return a list of successfully retargeted animation IDs?
This would however make usage more complex, so we might also require the animId parameter to be exactly one quint64 - I'll sleep over the question (still on tranqs ;-)
Wow, I just cnp'd this, so it's wrong everywhere?
Got to check.