Add a Filter Toolbar Button for Dolphin

Review Request #127054 - Created Feb. 12, 2016 and updated

Information
arnav dhamija
dolphin
15.08
Reviewers
dolphin, usability
emmanuelp

This patch was created to implement the feature suggested here: https://todo.kde.org/?controller=task&action=show&task_id=966

This patch adds a Filter Button to the toolbar of Dolphin. This button can be toggled to show/hide the Filter Bar.

In this patch, one might notice that there is now show_filter_bar and show_filter_bar_button in dolphinui.rc file. This was done because I found that using the same action for the menu entry and the toolbar entry would cause something to break (eg, shortcuts would stop working).

A screenshot of the toolbar is also attached.

manual

Files


Issues

  • 3
  • 11
  • 0
  • 14
Description From Last Updated
Please rename it to ShortcutFilter Emmanuel Pescosta Emmanuel Pescosta
I think that we should pass on the checked state to the handler, a ShortcutFilter should only filter on type ... Emmanuel Pescosta Emmanuel Pescosta
unused Emmanuel Pescosta Emmanuel Pescosta
arnav dhamija
Kai Uwe Broulik
Vedant Agarwala
arnav dhamija
Thomas Lübking
arnav dhamija
Emmanuel Pescosta
Emmanuel Pescosta
arnav dhamija
Thomas Lübking
arnav dhamija
arnav dhamija
arnav dhamija
Thomas Lübking
arnav dhamija
Emmanuel Pescosta
arnav dhamija
Emmanuel Pescosta
arnav dhamija
Review request changed
Emmanuel Pescosta

   
dolphineventfilter.h (Diff revision 12)
 
 
Please rename it to ShortcutFilter
dolphineventfilter.cpp (Diff revision 12)
 
 
I think that we should pass on the checked state to the handler, a ShortcutFilter should only filter on type ;)
dolphinmainwindow.h (Diff revision 12)
 
 
unused
Nathaniel Graham

What's the status of this patch? Should we migrate it to Phabricator?

  1. This patch is mostly complete, but I didn't finish it because of lack of time...and I really should get to doing it soon. Moving it to Phabricator is a good idea anyway.

Loading...