[klipper] Remove "Don't ask again" on clear clipboard history
Review Request #126907 - Created Jan. 27, 2016 and updated
When the clear clipboard history action is invoked klipper shows a message box asking whether that's really what the user intended as it's a potentially dangerous action (especially on a huge clipboard). But it also showed a "Don't ask again" checkbox which doesn't really make sense. When clicking "No" and the checkbox being checked it's becoming impossible to clear the clipboard which is probably not what the user intended. This change removes the "Don't ask again" checkbox. BUG: 336053
So, the situation is not that special: We ask for confirmation to err on the side of caution (which makes sense since there is no going back) but don't want to bother users with dialogs they don't care about. In fact, the situation is quite similar to removing Plasmoids.
Before considering any non-optimal solutions, here is what would be best from a user's perspective:
Do not ask for confirmation after deleting the history but don't really delete it immediately. Instead, just hide it at first, and replace the empty history area with an "Undo" button. When the user adds the next entry to the list (or alternativwely after some time), actually delete the history and remove the Undo button.
Yes, this would certainly be more complex to implement, but it would make the dialog unnecessary while still allowing recovery in case of deletion by accident and would set a good precedent (or rather follow the precedent of Plasmoid removal).