Fix QFileDialog::openUrl() for remote files

Review Request #126876 - Created Jan. 24, 2016 and submitted

Information
Kåre Särs
frameworkintegration
Reviewers
kdeframeworks
arichardson, dfaure
Qt does not know if the remote URL points to a file or directory. that is why options()->initialDirectory() returns the full URL even if it is a file.


This fix is a bit like Alex Richardson workaround in KIO (https://git.reviewboard.kde.org/r/126831/), but in frameworkintegration in stead (I did not see his/Your KIO fix before now...)

I check the remote url in setDirectory() because setDirectoy() is called from two places.

Kate now happily opens local and remote folders :)

Files


Issues

  • 3
  • 2
  • 1
  • 6
Description From Last Updated
Maybe also pass QUrl::StripTrailingSlash here? Alex Richardson Alex Richardson
Wouldn't it be a good practice to assume people are doing the right thing and not passing something that isn't ... Aleix Pol Gonzalez Aleix Pol Gonzalez
We shouldn't be calling sync API there. Aleix Pol Gonzalez Aleix Pol Gonzalez
David Faure
David Faure
Kåre Särs
Alex Richardson
Aleix Pol Gonzalez
Aleix Pol Gonzalez
David Faure
Kåre Särs
Review request changed

Status: Closed (submitted)

Change Summary:

Submitted with commit 18e62e74e840f3353dfd88a7f2c6b8b878e8511f by Aleix Pol on behalf of Kåre Särs to branch Plasma/5.6.
Loading...