Duplicate the file descriptor while opening

Review Request #126681 - Created Jan. 8, 2016 and submitted

Information
Martin Klapetek
kwallet
master
Reviewers
kdeframeworks
cullmann 
Closing the fd results in kwallet being in a blocked state

with all requests to it being timed out.


This fixes the issue.


Thanks to Christoph Cullmann spotting the issue.
KWallet no longer times out after login.
Martin Klapetek
Christoph Cullmann
Martin Klapetek
Review request changed

Status: Closed (submitted)

Change Summary:

Submitted with commit fe933214017df373af24428f5646d8fc8a3454ce by l10n daemon script on behalf of Martin Klapetek to tag v5.18.0-rc2.
Kai Uwe Broulik
Kai Uwe Broulik
I think we should do a re-spin of KF 5.18?
  1. I think it was already done: https://mail.kde.org/pipermail/release-team/2016-January/009263.html
  2. ok, I was just wondering because it wasn't mentioned in the changelog :)
  3. A changelog is only a summary of the changes that impact the users of the framework, not the full git log.
    

    When a release contains a change, and then a "oops" fix for the change, I remove the oops commit, it's irrelevant to the users of the release, who have never hit the temporary problem introduced by the first version of the change.
    

    To know if a commit is in a release, better trust the git tag.
  4. "I remove the oops commit" ... from the changelog, of course.
Loading...