Fix typos in code, remove inserted env variables on crash

Review Request #126655 - Created Jan. 6, 2016 and submitted

Information
Oleg Chernovskiy
kwin
Reviewers
kwin
graesslin

Currently on crash KWin will leave variables (such as DISPLAY, QPA_PLATFORM etc)
as-is so after crash backend selection functions assume we are in X11 environment
if XWayland was started previously. To get rid of this behaviour we need to cleanup
our environment to gain clean start point again

Started kwin_wayland in DRM mode on free terminal, observed crash and invalid backend selection afterwards
Started patched kwin_wayland in DRM mode, observed correct backend selection after crash

Files


Issues

  • 3
  • 1
  • 0
  • 4
Description From Last Updated
could this also be a static variable in KWin::Application? Martin Flöser Martin Flöser
QList<QByteArray>? Martin Flöser Martin Flöser
the for loop causes a detaching of the container. Range-based for and Qt's container don't work well together. Either use ... Martin Flöser Martin Flöser
Thomas Lübking
Oleg Chernovskiy
Thomas Lübking
Oleg Chernovskiy
Martin Flöser
Oleg Chernovskiy
Martin Flöser
Martin Flöser
Oleg Chernovskiy
Oleg Chernovskiy
Review request changed

Status: Closed (submitted)

Change Summary:

Submitted with commit 7ccca92c3e4ae0001a143e256956c97dfb3d50a7 by Martin Gräßlin on behalf of Oleg Chernovskiy to branch master.
Loading...