[Task Manager] Provide media controls in tooltips

Review Request #126647 - Created Jan. 5, 2016 and submitted

Information
Kai Uwe Broulik
plasma-desktop
master
352126
127744
Reviewers
plasma, usability
hein

This adds media player controls to the tooltip of a media player, using the already existing mpris dataengine this was pretty straightforward to implement.

When album art is available, no window thumbnails will be shown, instead the album art. There will be a close button on the album art closing the first window. Multiple windows for a player is uncommon and you can still access them all by clicking the task manager entry.

Interestingly enough, Amarok does not expose its album art through MPris. Also, if it wouldn't crash whilst doing so, you could control Amarok when it's main window is closed if you have a launcher pinned to your task manager, basically rendering its tray icon obsolete.

Works with VLC and Audacious, does not work with Dragon as the player announces itself as "dragonplayer" while its Desktop file says "dragon"

Files


Issues

  • 0
  • 1
  • 0
  • 1
Description From Last Updated
Martin Klapetek
Eike Hein
Kai Uwe Broulik
Heiko Tietze
Marco Martin
Kai Uwe Broulik
Marco Martin
Kai Uwe Broulik
Kai Uwe Broulik
Eike Hein
Kai Uwe Broulik
Review request changed

Status: Closed (submitted)

Change Summary:

Submitted with commit f9e87f911bb7823b1ae1aca16606cc9b50adf7e0 by Kai Uwe Broulik to branch master.
Luca Beltrame

This broke the task manager:

file:///usr/share/plasma/plasmoids/org.kde.plasma.taskmanager/contents/ui/main.qml:223:5: Type ToolTipDelegate unavailable
file:///usr/share/plasma/plasmoids/org.kde.plasma.taskmanager/contents/ui/ToolTipDelegate.qml:183:29: ToolTipWindowMouseArea is not a type

  1. Thanks, fixed, sorry. Reviewboard screwed up the patch...

Loading...