Do not unconditionally enable logging

Review Request #126630 - Created Jan. 5, 2016 and submitted

Information
Peter Wu
libkscreen
Reviewers
plasma, solid
dvratil, sebas

Logging is enabled by default, there is no read to use setFilterRules
and override any user preferences in QtProject/qtlogging.ini.

Keep unconditional logging enabled for the fake backend though, this
ensures that unit tests have log messages even if the user disabled all
other debug messages.

Tested on v5.5.2 (cherry-picked, ignored missing backends/kwayland/waylandbackend.cpp).

Test:

  1. Have no kscreen related lines in ~/.config/QtProject/qtlogging.ini
  2. killall kscreen_backend_launcher
  3. Change brightness levels via the keyboard. (Result: RRNotify_OutputProperty messages in journalctl)
  4. Add the following lines to qtlogging.ini:
kscreen.debug=false
kscreen.xrandr.debug=false
kscreen.xcb.helper.debug=false
  1. killall kscreen_backend_launcher
  2. Change brightness levels again. (Result: no log spam!)

Issues

  • 0
  • 1
  • 0
  • 1
Description From Last Updated
Daniel Vrátil
Peter Wu
Sebastian Kügler
Daniel Vrátil
Sebastian Kügler
Peter Wu
Review request changed

Status: Closed (submitted)

Change Summary:

Submitted with commit 649dda5e8c8f683f1650b4cf609fe094d22e3290 by Albert Astals Cid on behalf of Peter Wu to branch Plasma/5.6.
Loading...