Make svn::ContextP a QSharedPointer
Review Request #126558 - Created Dec. 29, 2015 and submitted
svn::ContextP was a svn::smart_pointer but sometimes also a simple pointer (svn::smart_pointer allows a promotion to a plain pointer). I changed this to a QShared/QWeakPointer.
In the callbacks SVN_NO_ERROR (0) or SVN_ERR_CANCELLED is returned (depending on whether there was a return path with SVN_ERR_CANCELLED already or not)
Runs fine here on my system since a few days
remove this line, since you removed the param
is this useful?
QObject::tr() is always wrong btw (it sets the context to "QObject"). When not in a class, the solution is QCoreApplication::translate("client_property", "Cancelled by user.").
(where client_property is the context, could also be Client_impl to group with the tr() calls in the Client_impl class in this file)