Show trailing spaces in diffbrowser
Review Request #126431 - Created Dec. 20, 2015 and submitted
Showing trailing spaces in the diff helps to avoid unnecessary changes. The highlight is done similar to reviewboard - the background color is changed to green/red/yellow (-/+/nothing changed) then.
Removed old, out-commented code (looks like this was from the qt3 -> qt4 port)
All the other highlightings are working still as expected.
|now it can be const ;)||David Faure|
Can idx be exactly 0? e.g. for a line of context (not changed).
Should we even be highlighting trailing spaces in non-modified lines, actually? I would say we shouldn't, it pushes people to mix whitespace changes and real changes.
If you set background == foreground, don't you end up with unreadable text? Anyway if this code is changed to only be executed if bIsModifiedLine then this condition can go away altogether.