[kdesvn] correctly allocate pool for svn char* ptr instead using a pointer to a temporary address

Review Request #126332 - Created Dec. 13, 2015 and submitted

Christian Ehrlicher
cgiboudeaux, dfaure

Inside svnqt there are 4 places where an assignment from a QByteArray to a char* ptr occours. One of them is in a function which is not used inside kdesvn, the other three are inside the ssl authentication functions which are maybe reported with Bug 338271. The problem is, that I don'T have a svn server with ssl authentication for testing... :(

Due to the function in libsvnqt which is not used inside kdesvn - now that this library is private I could remove all these useless function - what do you think?

Compiles fine, testing the three function is currently out of scope for me but the code chage is striaght-forward


  • 0
  • 1
  • 2
  • 3
Description From Last Updated
David Faure
David Faure
Christian Ehrlicher
David Faure
Christian Ehrlicher
Review request changed

Status: Closed (submitted)

Change Summary:

Submitted with commit 4224d826e0dde22c7915e37521ce3e7d42898f64 by Christian Ehrlicher to branch master.