ECMAddAppIconMacro: Add OUTFILE parameter

Review Request #126303 - Created Dec. 10, 2015 and updated

Information
Dominik Schmidt
extra-cmake-modules
Reviewers
extracmakemodules

On OSX I want to ship "Tomahawk.icns" instead of "tomahawkSources.icns" which is the autogenerated name for our sources variable, thus I added an optional paramater allowing to override the basename (without extension).

Tested it in Tomahawk and it works.

edit1: Actually, something is fishy. Still investigating.
edit2: Nope, everything's fine. Random CMake fnord, hadn't tried a clean build.

Issues

  • 2
  • 1
  • 0
  • 3
Description From Last Updated
Can we have a different parameter name, please? If I see OUTFILE, I expect it to be the actual file ... Alex Merry Alex Merry
Please add a "Since 5.19.0" (or whatever version the argument OUTFILE will appear in first) to the end of the ... Friedrich W. H. Kossebau Friedrich W. H. Kossebau
Dominik Schmidt
Dominik Schmidt
Alex Merry
Dominik Schmidt
Review request changed

Change Summary:

Added documentation

Diff:

Revision 2 (+15 -4)

Show changes

Alex Merry

   
modules/ECMAddAppIcon.cmake (Diff revision 2)
 
 
 
 
 

Can we have a different parameter name, please? If I see OUTFILE, I expect it to be the actual file name (probably a full path), not a basename. OUTFILE_BASE would work, but I'm open to suggestions.

Friedrich W. H. Kossebau

   
modules/ECMAddAppIcon.cmake (Diff revision 2)
 
 

Please add a "Since 5.19.0" (or whatever version the argument OUTFILE will appear in first) to the end of the description of the argument.

Aleix Pol Gonzalez

What's the status there?

  1. I've just picked it up again, will open a new request in Phabricator.

Loading...