Rework the notifications positioning a bit

Review Request #126221 - Created Dec. 2, 2015 and submitted

Information
Martin Klapetek
plasma-workspace
355069
126597
Reviewers
plasma

The notifications popup positioning recently regressed
by some other changes (looks like Qt) and the popups
would fly across the screen (bug 355069).

The proper solution is using KWin effect but given how
close the release is, this needs to be dealt with in a
different way.

The main problem is calculating the initial popup size
because as long as the Dialog is invisible, it has an
incorrect geometry, so it needs to be positioned right
after it's being displayed. The Dialog however gets the
sizes even later, so the code now calls a slot from Dialog
that ensures the sizes are correct before the initial
placement on screen. It's not ideal but I'm out of ideas
otherwise. Plus it should be only temporary until the
KWin effect will replace it.

I can no longer reproduce notifications flying across
the screen.

Issues

  • 0
  • 1
  • 2
  • 3
Description From Last Updated
David Edmundson
David Edmundson
Mark Gaiser
Bhushan Shah
Martin Klapetek
Review request changed

Status: Closed (submitted)

Change Summary:

Submitted with commit 4a6f7db0018a2a7366ac7f2ad61fc33f31566c03 by Martin Klapetek to branch Plasma/5.5.
Martin Flöser

I'm glad that you found a solution which works just in time for the release! Good work!

Loading...