Krazy fixes: Check for code that should be considered crashy. [crashy]
Review Request #126211 - Created Nov. 30, 2015 and submitted
Fix some (3 files with a lot of such changes are still left) krazy warnings about QDialog::exec() usage with a QDialog object on the heap.
I fixed it like explained in the blog post - use QPointer + delete
Compiled and opened some (not all) of the affected dialogs and it still works as expected.
thisis a widget, I wonder why it's not used as the parent widget here, rather than activeModalWidget().
useless given exec() is called below
this is a behaviour change; should cancelling the dialog really still change anything in the data structures?
Ouch, my eyes.
KUrl -> QString -> QByteArray -> QUrl -> QString -> KUrl ... really? :-)
There's no reason I can see why this isn't just
ret = KUrl(url.trimmed());
This will still do what the comment says.
Fixed issues found by dfaure, fixed some possible nullptr-accesses. Added some forgotten some QPointer<> guards.
Revision 2 (+155 -139)