WIP: Allow using QTextBrowser for documentation instead of QtWebKit

Review Request #126156 - Created Nov. 24, 2015 and updated

Information
Alex Richardson
kdevplatform
129224
b50f981...
Reviewers
kdevelop
rjvbb

Allow using QTextBrowser instead of QtWebKit

compiles on my system which no longer has QtWebKit

Issues

  • 0
  • 4
  • 0
  • 4
Description From Last Updated
Aleix Pol Gonzalez
Andrew McCann
Alex Richardson
Kevin Funk
Alex Richardson
René J.V. Bertin
Eike Hein
Alex Richardson
Review request changed

Change Summary:

rebased and made suggested changes

Commit:

-3de05f1607db7d3dd265e166f8f294bfee8e4891
+b50f9813126f7247b7f857205a072689da8d9c81

Diff:

Revision 3 (+83 -18)

Show changes

Eike Hein

This needs rebasing again after the buildsystem/webengine changes ... please save my sanity :(

  1. webengine changes

    ? This is about using QTextBrowser instead of WebKit, so where does WebEngine come in? (I thought there was some agreement not to let KDevelop depend on that behemoth?!)

  2. Basically build system stuff in kdevplatform was shuffled around when WebEngine support was added. It can use both WebEngine and WebKit now, but I don't want to build either, so ...

  3. Yikes, yes. WebKit is one thing (I actually use it), WebEngine with its helper process(es) another... I have it installed so I hope it's not going to invite itself in my build once support for it appears in the 5.1 branch or I go back to using the master branch.

    Is either actually required for the documentation popup windows?

    In fact, my suggestion here would be:
    - use QTextBrowser (or some derivative) in KDevelop
    - move the help/documentation components that could benefit from more capable HTML rendering to a standalone application (or a KPart that can either be loaded in KDevelop or in some dedicated shell application).

    I have a hunch this would also reduce KDevelop's memory footprint if you use the documentation toolview(s)/plugin(s). And on Mac it could help prevent filedescriptor depletion when you have lots of Qt compressed help files.

Friedrich W. H. Kossebau

Alex, could you please discard this one, given the patch no longer applies? As part of cleaning up reviewboard in preparation of its shutdown.
Any reworked version please then should be handed in on phabricator instead. Seems request for a QTextDocument-based alternative is out there with a few people, so they would like that :) (not that it will work with doxygen-created QCH files, but some docs are better than no docs)

Loading...