[KFileItemModelRolesUpdater] Check icon validity before using it

Review Request #125998 - Created Nov. 8, 2015 and discarded

Information
Kai Uwe Broulik
dolphin
master
Reviewers
dfaure, emmanuelp

For some exotic file types where I don't have an icon (such as Audacity project, or Android package because the icon name and mimetype don't match up) I got a blank icon rather than the unknown filetype icon.

I now at least get an "unknown" icon. Not sure if the approach is worth it for such corner cases or okay, I cache the results because QIcon::fromTheme apparently causes loads of IO. (I just saw there's a KIconLoader::hasIcon() ... probably better to use that one?)

Issues

  • 0
  • 0
  • 1
  • 1
Description From Last Updated
David Faure
Kai Uwe Broulik
Emmanuel Pescosta
Kai Uwe Broulik
Review request changed

Status: Discarded

Loading...