fix homepage link: Insert empty otherText in KAboutData constructor
Review Request #125992 - Created Nov. 8, 2015 and submitted
The hyperlink in >Help >About Picmi does not work, because the hyperlink
is put in the place of the additional free form text for that dialog.
This was probably an accident in commit 7ab84ae5b3a... when porting to
KF5. Fix it by inserting a QString().
Compiling, Running. Clicking on the hyperlink.
I know, not directly related to your change, but maybe Jakob can answer, why the link goes projects.kde.org, while there is something more colourful like https://games.kde.org/picmi ? :)
Other than that, your fix is valid. ... ... although :D
It might be more readable to give the constructor only everything until the copyright info and then use .setHomepage() to set the URL.
Here the (simplified) code from KShisen:
KAboutData aboutData(QStringLiteral("kshisen"), i18n("Shisen-Sho"), QStringLiteral(KSHISEN_VERSION), i18n(description), KAboutLicense::GPL, i18n("(c)")); aboutData.setHomepage(QStringLiteral("http://games.kde.org/kshisen"));