Optimize string operations

Review Request #125933 - Created Nov. 3, 2015 and submitted

Information
Nick Shaforostoff
kwin
master
Reviewers
kwin
graesslin
I have changed the code to use QByteArray in many places (to avoid 8->16->8 converting with the data that is expected to be Latin1 only), and QStringRef in few others. For comparing strings QLatin1String performs better than QStringLiteral.

One AniData ctor was missing windowType member initialization so i have zeroed it.

Also this patch contains fix for Coverity issue #1291360:
https://scan5.coverity.com/reports.htm#v39099/p10103/fileInstanceId=82671774&defectInstanceId=24554425&mergedDefectId=1291360
(missing initialization for can_wobble_*)

compiles fine. i expect that the reviewer will check that the code doesn't break anything in the runtime (it shouldn't but who knows)

Issues

  • 0
  • 2
  • 0
  • 2
Description From Last Updated
Martin Flöser
Martin Flöser
Thomas Lübking
Nick Shaforostoff
Martin Flöser
Martin Flöser
Nick Shaforostoff
Review request changed

Status: Closed (submitted)

Change Summary:

Submitted with commit 3a8d7d866ada5f24fc7313bfd094a076943ec8ce by Nick Shaforostoff to branch master.

Loading...