change QT_IMPORTS_DIR to also cover false and NOTFOUND

Review Request #125880 - Created Oct. 30, 2015 and submitted

Information
Harald Sitter
marble
master
46f8409...
Reviewers
marble
bshah

if(DEFINED var) only checks if the var is defined, but with certain Finders
var can be set but NOTFOUND.

For the purposes of the if at hand we want to make sure that we have a
*valid* QT_IMPORTS_DIR not just a set one. To that end if(var) is the
correct instruction here as var being undefined, 0, OFF, IGNORE or NOTFOUND
will end up as a false condition making sure that we only set
MARBLE_QT_IMPORTS_DIR to the value of QT_IMPORTS_DIR iff it is a truthy
value.

checked that if(var) in fact evaluates to false on undefined vars. I do not have a test case at hand as this is to get rid of a debian patch that never was forwarded http://anonscm.debian.org/cgit/pkg-kde/applications/marble.git/tree/debian/patches/fix_qmake_fallback.diff?id=74c0c6fb8ac8cdad09c6d7ec86f881af10e029a8

Bhushan Shah
Dennis Nienhüser
Harald Sitter
Review request changed

Status: Closed (submitted)

Change Summary:

Submitted with commit f93278cbeeeb5c1a5987ff97d47c81e467c986ab by Dennis Nienhüser on behalf of Harald Sitter to branch master.
Loading...