preliminar support for task geometries in wayland

Review Request #125873 - Created Oct. 29, 2015 and submitted

Information
Marco Martin
kwin
Reviewers
kwin, plasma

make the minimize effect work by reading taskGeometry from plasmawindowmanagement and returning as iconGeometry().

It still supports a single taskbar as on x11. the architecture will have to change somehow to allow to know from where panel we want to minimize (or if not secified searching for the nearest panel)
suggestions welcome :)


  

Issues

  • 7
  • 4
  • 0
  • 11
Description From Last Updated
why friend an inheriting class? Martin Flöser Martin Flöser
cough, kate/kwrite/kdevelop btw. has this fancy feature to autofix that for you (and so does vim ;-) Thomas Lübking Thomas Lübking
can we please go for for (auto i = windowManagementInterface()->taskGeometries().constBegin(), end = windowManagementInterface()->taskGeometries().constEnd(); i != end; ++i) instead of while ... Thomas Lübking Thomas Lübking
local variable, "const int distance = ..." - this ain't C-99 ;-) Thomas Lübking Thomas Lübking
take a close look at this line, then fix it :-) Thomas Lübking Thomas Lübking
nitpick Martin Flöser Martin Flöser
nitpick Martin Flöser Martin Flöser
Marco Martin
Marco Martin
Martin Flöser
Marco Martin
Marco Martin
Thomas Lübking
Marco Martin
Marco Martin
Martin Flöser
Marco Martin
Review request changed

Status: Closed (submitted)

Change Summary:

Submitted with commit 1f9fa64a4936ab85ccb2816c7aa60a01433a69b7 by Marco Martin to branch master.
Loading...