WIP: task geometries to wayland for minimize effect

Review Request #125871 - Created Oct. 29, 2015 and submitted

Marco Martin
kwin, plasma

this exposes the geometry of taskbar entries in plasma-windowmanagement, in order to make the minimize effects possible.
unlike on X11, it takes relative positions and it has one geometry per panel, making possible to have multiple taskbars working.

however this is still not completely exposed, as internally kwin has still only one geometry, it will need a change in kwin itself (suggestions welcome) probably the rotocol will need also a minimizeTo function that takes the panel as argument.

another thing completely missing is tests: unfortunately the whole plasma-windowmanagement doesn't have any autotest yet :/



  • 10
  • 5
  • 0
  • 15
Description From Last Updated
if (panelSurface) ... Thomas Lübking Thomas Lübking
if (p->taskGeometries.remove(.)) ... Thomas Lübking Thomas Lübking
same checks here Thomas Lübking Thomas Lübking
nitpick Martin Flöser Martin Flöser
@since 5.5 Martin Flöser Martin Flöser
why QRectF and then toRect()? Martin Flöser Martin Flöser
I don't remember having written that code :-P For you it should be add first name, remove last name, exchange ... Martin Flöser Martin Flöser
the setter differs from the getter? Thomas Lübking Thomas Lübking
stray semicolon Thomas Lübking Thomas Lübking
emitted unconditionally Thomas Lübking Thomas Lübking
Thomas Lübking
Marco Martin
Thomas Lübking
Martin Flöser
Martin Flöser
Martin Flöser
Marco Martin
Review request changed

Status: Closed (submitted)

Change Summary:

Submitted with commit 3d41b6fc726ed0fb9589e5fbefa1b07821cbc7c7 by Marco Martin to branch master.
Thomas Lübking


the setter differs from the getter?

mitted unconditionally (on idempotent sets)

stray semicolon

emitted unconditionally

sorry for the post review (and in case this has been addressed for the ultimate commt)

  1. last commit on master should address those comments