Fix crash when exiting kscreen kcm in systemsettings

Review Request #125734 - Created Oct. 21, 2015 and submitted

Information
Martin Flöser
kscreen
Plasma/5.4
344651
8eb2b58...
Reviewers
plasma
broulik, dvratil
When using threaded rendering loop [1] systemsettings crashed when
clicking the back button. This crash is caused inside the shader effect
used by the OpacityMask.
QtQuick informed us also that something is wrong:
"QSGDefaultLayer::bind: ShaderEffectSource: 'recursive' must be set to true when rendering recursively."

The actual problem is that orientationPanelContainer and the OpacityMask
are children to the monitor item causing recursion. By making them
siblings to the orientationPanelContainer the problem is resolved. The
error message from QtQuick is no longer shown and systemsettings doesn't
crash any more.

BUG: 344651
FIXED-IN: 5.4.3

[1] QSG_RENDER_LOOP=threaded systemsettings5

  
Christoph Feck
David Edmundson
Martin Flöser
Review request changed

Status: Closed (submitted)

Change Summary:

Submitted with commit 4653c287f844f2cb19379ff001ca76d7d9e3a2a1 by Martin Gräßlin to branch Plasma/5.4.
Loading...