Don't assume dbus-launch autolaunch is still broken

Review Request #125637 - Created Oct. 14, 2015 and submitted

Information
David Edmundson
plasma-workspace
c04d3ee...
Reviewers
plasma

1) it's not broken, that comment is ancient

2) the test is bust. DBus path can also be stored as an x property.

Before this patch the situation is worse as potentially we risk
launching two dbus daemons for the same session.

BUG: 352251

See last comment in bug.

The part regarding the env var is true. If it's autolaunched, there's no way that the application could write into the env of the parent process.
I tested that connecting to dbus with a valid $DISPLAY but no DBUS_SESSION_BUS_ADDRESS and that works.

Change shouldn't affect anyone as all proper DMs will spawn dbus properly anyway. If that wasn't working we'd see more bug reports about ksplash locking - as we adjusted that to use dbus without reordering startkde.

Aleix Pol Gonzalez
Martin Flöser
David Edmundson
Review request changed

Status: Closed (submitted)

Change Summary:

Submitted with commit f949f161a77114203d0489b2020011be019b47d0 by David Edmundson to branch master.
Loading...