Handle kabc deprecated classes in kabc->kcontact porting script

Review Request #125570 - Created Oct. 9, 2015 and submitted

Information
R.Harish Navnit
kde-dev-scripts
master
Reviewers
kdeframeworks, kdepim
apol, mlaurent

A lot of KABC classes are deprecated in KF5. The porting script only replaces kabc occurences to kcontacts, but overlooks if the class being used still exists in kcontact or not. This leads to a lot of compile time #include<> errors. I feel this should and can be avoided by modifying the script. Was this overlooked on purpose or did we just miss it out ?

I've really no prior knowledge or experience of working with perl and I've tried to handle the above mentioned scenario, by manually checking for deprecated classnames and replacing them with a blank space or commenting them out.

Ran the script on the kopete codebase which uses deprecated classes like addressbook, stdaddressbook, resource etc.
Works fine, but takes a bit of time to execute.

Issues

  • 0
  • 1
  • 0
  • 1
Description From Last Updated
R.Harish  Navnit
Daniel Vrátil
R.Harish  Navnit
R.Harish  Navnit
R.Harish  Navnit
R.Harish  Navnit
R.Harish  Navnit
David Faure
R.Harish  Navnit
David Faure
R.Harish  Navnit
Review request changed

Status: Closed (submitted)

Change Summary:

Submitted with commit 5a9193879ea5a779f2e8887c65c666d2f2721d3b by R. Harish Navnit to branch master.
Loading...