Use NETRootInfo to initiate wm move operation
Review Request #125522 - Created Oct. 4, 2015 and submitted
Also remove hack that messes with cursor position, which results in window sometimes rendered in wrong position for a moment after starting window move.
I'm not sure why there was added a button release before ungrabbing pointer in startDrag(), but it works fine without it.
Moving windows still works.
I cannot reproduce the issue described in comment of the mentioned hack.
Should also be checked when compiling against kde4 (cmake -DUSE_KDE4=1)
As far as I can tell, right now it does not compile there.
Also, concerning the added release, and other hacks, this was needed because in the past at least, when dragging the window, you would immediatly after miss one click as well as hover highlight.
I'll double check if this is still the case (against kf5).
Tested it, works ok, for both kde4 and kf5.
On the extra mouseRelease event, did you test removing it ? for both kde4 and kf5 ?
If yes, feel free to remove it too (in which case the whole method can go).
And yes: if it only is unnecessary for KF5, just ifdef it.
Note: a similar patch should probably also be applied to kde/workspace/oxygen. Feel free to implement it there too and commit at will. I'll do it otherwise, in case you don't have time.
Status: Closed (submitted)
Submitted with commit ca72ca904f7fb8872667322bf5143e2b81eaf2f3 by Hugo Pereira Da Costa on behalf of David Rosca to branch Plasma/5.4.
This was commited as 454483b51f86f0b15403ffdf6643735100080565 (in Plasma/5.4)
Chronological later commit b2c06365a27fb89e61ce00831fdfa949627c1e24 (in master)
then restored the mouse override with an ifdef.
No clue which of the two should win in a merge. Therefore I can't merge 5.4->master. Maybe someone could fix that please.