Fix header encryption in cli7z

Review Request #125507 - Created Oct. 3, 2015 and submitted

Information
Ragnar Thomsen
ark
master
Reviewers
kdeutils
elvisangelaccio

7z gives an error when using the header encryptions switch (-mhe=on|off) with archive types that don't support header encryption such as zip. This results in Ark failing to create new zip archives with cli7z.

This is now fixed by setting $EncryptHeaderSwitch to empty when header encryption is off, instead of -mhe=off.

This patch also fixes CreateDialog::isHeaderEncryptionChecked() to only return true if encryptHeaderCheckBox is both enabled and checked, instead of just checked.

  • Create new zip archive with/without encryption works.
  • Create new 7z archive with/without header encryption works.

Issues

  • 0
  • 1
  • 0
  • 1
Description From Last Updated
Elvis Angelaccio
Ragnar Thomsen
Review request changed

Status: Closed (submitted)

Change Summary:

Submitted with commit d3286f07349f8733603d1e351f7629876e7d8fb0 by Ragnar Thomsen to branch master.
Loading...