Unselect text when the text tool is deactivated.
Review Request #125485 - Created Oct. 2, 2015 and updated
Otherwise text remains selected in Stage after switching to another shape, which is very unexpected.
This change would go against a lot of special code that ensures the selection stays so I would not like this to go in - what i am not getting is why this is a problem - when the textshape is no longer selected the text is not either - so can you please explain a bit more - if I get it right the problem is more that the textshape stays selected when the slide is changed
Added screenshot. Steps to reproduce: select text in a text box, then click on the "Shape Handling Tool" tab, then click on another text shape.
Indeed if I start editing in that second text shape the selection in the first one disappears. It just looks quite odd to be in this situation where text is selected even though I'm not editing that box anymore. I admit that nothing really bad happens from there (it doesn't actually show as selected if I start the presentation), but it just looks buggy. And indeed I can even switch slides and come back, and this piece of text is still selected.
But maybe the fix isn't the one I'm providing here.
I'd prefer if this doesn't go in In words at least it's on purpose that we keep the text selection. 1) because we wan't it to be selected so other tools can work with it 2) we want it to be there when the text tool is reactivated some other solution might eventually work like not render the selection if the current tool doesn't want it to be rendered