Make tooltip dialog hidden on the cursor entering the inactive ToolTipArea

Reviews
Diff

- Download Diff

Information
Submitter:	Takahiro Hashimoto
Repository:	plasma-framework
Branch:	master
Bugs:
Depends On:
Blocks:	125402
Reviewers
Groups:	plasma
People:

Description

Now PlasmaCore.ToolTipArea can control status of active/inactive.

When a ToolTip dialog is visible and making mouse move to another inactive ToolTipArea, it remains unnaturally for a while.

I attached a urgy test program to reproduce this behavior. The instruction to reproduce is:

1.run qmlscene tooltip_hide.qml
2. make mouse cursor on the cell named "name1" (or any odd numbered one)
3. move the cursor to a even numberd cell like "name2"

It results the "tip1" tooltip remains for a long time (current spec is 4000ms)

I think it would be better when a mouse entered into an inatcive ToolTipArea, the global tooltip dialog is dismissed soon. This patch is the implementation of this behavior.

I cannot check all side-effect to change this behavior. Many guys adivce are welcomed:)

Here's my reference use case: https://git.reviewboard.kde.org/r/125402/

Testing Done

Apply patch and build and test on master.

Tested with my test program attached this review request. Works fine to me.

Files

Issues

0
1
0
All Issues: 1

Description	From	Last Updated
I don't think you need the dismiss, It seems we can just wrap this keepAlive line in an if(m_active) Otherwise ...	David Edmundson	Sept. 30, 2015, 1:43 a.m.

Change Summary:

Add reference to my use case.

Description:

		Now PlasmaCore.ToolTipArea can control status of active/inactive.

		When a ToolTip dialog is visible and making mouse move to another inactive ToolTipArea, it remains unnaturally for a while.



		I attached a urgy test program to reproduce this behavior. The instruction to reproduce is:

		1.run qmlscene tooltip_hide.qml
		2. make mouse cursor on the cell named "name1" (or any odd numbered one)
		3. move the cursor to a even numberd cell like "name2"

		It results the "tip1" tooltip remains for a long time (current spec is 4000ms)

		I think it would be better when a mouse entered into an inatcive ToolTipArea, the global tooltip dialog is dismissed soon. This patch is the implementation of this behavior.

		I cannot check all side-effect to change this behavior. Many guys adivce are welcomed:)
	+
	+	Here's my reference use case: https://git.reviewboard.kde.org/r/125402/

src/declarativeimports/core/tooltip.cpp (Diff revision 1)

Show all issues

I don't think you need the dismiss, It seems we can just wrap this keepAlive line in an if(m_active)

Otherwise this will have odd effect in nested ToolTipAreas even if only one is active.

Takahiro Hashimoto Sept. 30, 2015, 1:08 a.m.

Thank you for your review and comment. I agree all with you. I'd like to update my patch.

And I also agree with your additional comment below. I'd like to add patch for tooltip.qml if it's ok to include it in this change request.

Thanks for doing a test! it allowed me to test my comment above.

it'll be good to have it commited somewhere for future edits.
there's an existing tests/tooltip.qml that doesn't have any inactive areas maybe we can add one in the middle there?

Change Summary:


Make dialog keepalive trigger simple
Update tests/tooltip.qml for inactive ToolTipArea case.

Diff:

Revision 2 (+26 -3)

Show changes

	src/declarativeimports/core/tooltip.cpp
	tests/tooltip.qml

Change Summary:

upload tests/tooltip.qml screenshot

Added Files:

How about updated pacth?

David Edmundson Oct. 2, 2015, 11:16 a.m.

Ever so sorry, I didn't see you updated this :S
Looks perfect.

Thanks for reminding me.

Takahiro Hashimoto Oct. 2, 2015, 2:22 p.m.
```
NP. Thanks again for your kind support:)
```

Ship it!

Ship It!

Status: Closed (submitted)

Change Summary:

Submitted with commit 64b951fab3fc0dbbb1eedd9e35eb59ddbaa6da1f by Takahiro Hashimoto to branch master.

You have a pending review.

Review Board 2.5.15

Screenshots

Files

Issues

Change Summary:

Description:

Change Summary:

Diff:

Change Summary:

Added Files:

Status: Closed (submitted)

Change Summary: