Add an "Open" action

Review Request #125339 - Created Sept. 21, 2015 and submitted

Information
Ragnar Thomsen
ark
master
201162, 208330
Reviewers
kdeutils, usability
elvisangelaccio, rkcosta

Add an Open action, which opens an archive entry with the associated application. This was previously only possible through the "Open With" action, but this required several clicks. Currently, the Preview action is still the default, i.e. when the user clicks an archive entry the Preview action is called.

QSignalMapper is used to connect the signals from the Open, Open With and Preview actions to the same slot.

As for Preview, the file is extracted to a QTemporaryDir and then opened. The temporarily extracted file is monitored for changes using QFileSystemWatcher and on change a KMessageBox is opened to query the user if the archive should be updated with the modified file. If the user accepts slotAddFiles() is called.

The previously unimplemented path argument of slotAddFiles() is used to allow for updating a file in a subdirectory within the archive.

Things to consider:
1. Should we set some default keyboard shortcuts for "Open File" and "Open File With"? If yes, which?

Tested with tar-based, zip, rar and 7z archives.

Files


Issues

  • 0
  • 7
  • 0
  • 7
Description From Last Updated
Thomas Pfeiffer
Elvis Angelaccio
Ragnar Thomsen
Ragnar Thomsen
Ragnar Thomsen
Elvis Angelaccio
Ragnar Thomsen
Elvis Angelaccio
Ragnar Thomsen
Review request changed

Status: Closed (submitted)

Change Summary:

Submitted with commit f1cf10f25af245823f81b8ff457a04c7593dede7 by Ragnar Thomsen to branch master.
Loading...