Port part of KCalUtils::IncidenceFormatter to Grantlee template system

Review Request #125331 - Created Sept. 20, 2015 and submitted

Information
Daniel Vrátil
kcalutils
master
Reviewers
kdepim
mlaurent, vkrause

I needed to extend the HTML generated for todos so that it includes some more fields useful for the Phabricator resource. After digging around the code a bit a decided to see if I can port it to Grantlee, which is way easier to maintain and modify and also provides much cleaner separation between logic and representation and this is the result of it :)

This patch does not port the entire IndicendeFormatter to Grantlee, only events, tasks, journals and free/busy, I haven't touched the ITIP formatter yet.

The new code works just fine, but I consider it more of a proof-of-concept than a ready-to-ship patch and I'd like to get your input regarding the use of Grantlee - should we use a QObject wrapper for KCalCore::Incidence instead of QVariantHash, or maybe use the Grantlee MetaType system directly for thinner-than-QObject wrappers, should we use the custom Grantlee plugin, ...?

Also please see the mail on kde-pim regarding where should we put the plugin :)

I can see my events.

Issues

  • 0
  • 28
  • 6
  • 34
Description From Last Updated
Daniel Vrátil
Laurent Montel
Laurent Montel
Allen Winter
Sandro Knauß
Daniel Vrátil
Sandro Knauß
Daniel Vrátil
Sandro Knauß
Laurent Montel
Sandro Knauß
Daniel Vrátil
Sandro Knauß
Daniel Vrátil
Review request changed

Status: Closed (submitted)

Change Summary:

Submitted with commit c0c318942bc70714091b59fa078ee62332e8a60f by Dan Vrátil to branch master.
Loading...