Fix build on OS X

Review Request #125072 - Created Sept. 6, 2015 and updated

Information
Samuel Gaist
kwalletmanager
master
2d51468...
Reviewers
kdeutils
vrusu

like msvc, clang doesn't know about __uid_t, this patch adds it to the list

Build on OS X 10.8

Issues

  • 1
  • 2
  • 0
  • 3
Description From Last Updated
BTW: Commit this file separately (does not even need review) Kevin Funk Kevin Funk
Raphael Kubo da Costa
Raphael Kubo da Costa
Samuel Gaist
Lindsay Roberts
Samuel Gaist
Review request changed

Commit:

-19dad6545bd1e03c0464f96b93fd934ea22d534f
+2d514688fb699fc1095c5ffd44109389e33a5cc3

Diff:

Revision 3 (+11 -4)

Show changes

Raphael Kubo da Costa

Given all this effort is only used to print a debugging line, how about fixing the TODO item and doing qDebug() << "Executing uid=" << getuid()? I don't really see why __uid_t is being used in the first place.

  1. Note: getuid() is not portable either. Not available on MSVC. Please either remove completely or wrap this line in #ifdefs...

  2. Should we provide an implementation using GetUserName https://msdn.microsoft.com/en-us/library/ms724432(VS.85).aspx for Q_OS_WIN ?

  3. Honestly, I don't think it's worth it. It's just a debug statement after all. Just remove it altogether?

  4. KDE with KF5 now use C++11. Did you try using 'auto' keyword instead of trying to get the right type with that #ifdef ?

Kevin Funk

   
.reviewboardrc (Diff revision 3)
 
 

BTW: Commit this file separately (does not even need review)

  1. Do you mean push the .reviewboardrc directly ?

Loading...