Re-organize D-Bus interfaces
Review Request #124919 - Created Aug. 25, 2015 and submitted
- Previously mainhub class was being used to forward D-Bus calls to relevant objects
- Now each object that needs D-Bus communication is registered as a separate D-Bus object and communication takes place directly.
- FileContentIndexer has been made a long lived class now to register a D-Bus object for it.
baloo-monitor and balooctl seem to be working as before.
Looks good. The only minor thing I realized is that I'm not sure how QtDbus behaves with interfaces which appear and disappear (contentIndexer).
Maybe just 'fileIndexer' or some similar small word? This is quite the mouthfull.
This might not be thread safe.
It calls batchTimings which accesses
m_batchTimeBuffer. This variable is also being modified in the
runmethod which runs in another thread.
Maybe we can just use '/'? This is getting a bit wordy, and is exposing the internal class name/structure.
Status: Closed (submitted)
Submitted with commit fa053a62c52a0630c6ee6f7b46f160c34dc1306a by Pinak Ahuja to branch master.