Cache a KEmoticons instance here, not a KEmoticonsTheme.

Review Request #124878 - Created Aug. 22, 2015 and submitted

Information
Volker Krause
kemoticons
master
bf685e6...
Reviewers
kdeframeworks
This already contains a cache for the theme, and it is expensive to create
itself. Cuts down the cost in half here.

Still not perfect though, the currentThemeName() call in theme() parses
kdeglobals every time. And this is called per line for KMail's message
rendering, resulting in more than 15% of the instructions spend in KConfig
parsing code.

Callgrind + KMail.

David Faure
Volker Krause
Review request changed

Status: Closed (submitted)

Change Summary:

Submitted with commit 977afe65ac657f19795effae24059ac298cfe16a by Volker Krause to branch master.
Loading...