[solid-device-automounter] Port to KF5
Review Request #124730 - Created Aug. 13, 2015 and submitted
|Kai Uwe Broulik|
This is a straight port of the solid-device-automounter from kde-runtime that was somehow lost to plasma-desktop. I didn't do git graft magic (can this be done later? ie. import kde-runtime folder here to there and then apply a diff on top?).
Seems to work, translations are probably broken.
Told it to auto mount all the things, did that. Told it to mount just one thing automatically, did that. Somehow the list of non-attached devices grows even when I re-attach the same device.
done the KCM. not looked at kded
you missed a thing
someone didn't know you can connect a signal to a signal...
(probably not your code, don't feel you have to change it)
these layoutChanged bits don't belong here
layoutChange is a sort of a mini modelReset()
same for the rest of this class.
this isn't right
that's inserting two things into the model
Maybe the layoutChanged was hiding it.
Fix issues; I couldn't directly connect to the signal using new connect syntax.
Also try harder not to show any gibberish by checking "isIgnored" - this way my only /dev/sdc1 shows up for my USB drive (like everywhere else) but not /dev/sdc and /dev/sdc2
Also don't feel the need to tell me about the qDebug screaming or typo in the comments, fixed that locally
do we need a set_translation_domain?
I don't think it comes from KAboutData anymore as the i18n domain is done at compile time.
Though I really don't understand most this i18n stuff.
might be worth dropping an email to i18n to copy the old pot files from kde-runtime, it might save translations some effort?
sa could be null here based on the comment above, at which point you get a huge warning from Qt.
this comment doesn't match line 72
we're doing this if the device-specific automount is false.
I /think/ it's the comment that's wrong rather than the code
The code says: If there's no device specific setting, look at general settings.
which makes sense.
All reviewed. Only some minor comments, then I think we're all good.
Revision 3 (+1903 -1)