Adapt CMakeLists.txt to kf5

Review Request #124721 - Created Aug. 12, 2015 and submitted

Information
R.Harish Navnit
kopete
master
130014
Reviewers
kopete
mlaurent, pali

Changes obtained by running the kde-dev-scripts/adapt_cmakelists_file script. Adapt CMakeLists.txt for kf5 port.

cmake build succeeds.

Issues

  • 14
  • 3
  • 0
  • 17
Description From Last Updated
remove it and all KDE4_* Laurent Montel Laurent Montel
qt-mt ? Laurent Montel Laurent Montel
Add info about commented code ? MESSAGE(STATUS "commented code ....") Laurent Montel Laurent Montel
Please clean cmake files. Do not let such lines with whitespaces... Pali Rohár Pali Rohár
Please, move all find_package() macros into main CMakeLists.txt file Pali Rohár Pali Rohár
These KF5 libs do not have cmake variable? It is really preferred format to hardcode them? Pali Rohár Pali Rohár
If those files are really not used, removed them. Do not comment. Pali Rohár Pali Rohár
Need to change VERSION and SOVERSION according to semversion scheme. KF5 is ABI incomaptible with KDE4. Pali Rohár Pali Rohár
Reason for this? Pali Rohár Pali Rohár
Incorrect parsing of if/endif. Pali Rohár Pali Rohár
Drop IRC code. It is not working with KDE4, so there is no need to port it into KF5. Pali Rohár Pali Rohár
We are not using this cmake file. Do not change it. Pali Rohár Pali Rohár
Same here. Pali Rohár Pali Rohár
Why commented line above? And is this change ok? Pali Rohár Pali Rohár
Laurent Montel
Pali Rohár
Pali Rohár
Luigi Toscano
R.Harish  Navnit
Review request changed

Status: Closed (submitted)

Loading...