do not install namelink for private library

Reviews
Diff

- Download Diff

Information
Submitter:	Harald Sitter
Repository:	baloo
Branch:	master
Bugs:
Depends On:
Commit:	66dbdd7...
Reviewers
Groups:	baloo, buildsystem, kdeframeworks
People:

Description

please note that the private target is appearing in the resulting cmake

config all the same and we cannot prevent this because of a cmake oddity

Alex Merry was kind enough to track down [1].

testing suggests that this is however not breaking anything (what with the

library being private).
[1] http://public.kitware.com/pipermail/cmake-developers/2015-July/025798.html

Testing Done

make && make install
no .so symlink installed

made sure there is no symlink on the system and rebuilt gwenview:
gwenview builds just fine

I have no idea what this does. Someone else will need to give it a ShipIt. Also, you probably want to get this in today before the tagging.

Harald Sitter Aug. 4, 2015, 8:46 a.m.

Actually I'd rather put it in after tagging so we get a month worth of CI on top of the change. KGlobalAccel has the same problem and was released with it, so I suppose we can live with the .so symlinks for another month to make sure nothing breaks.

Since the libs are not considered public and cannot be linked against unless one actually copies the headers from the framework source the symlink on its own doesn't cause immediate concern anyway.

Ship it!

definitely a "good thing" for private libraries (without public api).

Status: Closed (submitted)

Change Summary:

Submitted with commit 9807ff7416f651a0daf289b7bd024a7bb9952f99 by Harald Sitter to branch master.

You have a pending review.

Review Board 2.5.15

Screenshots

Files

Status: Closed (submitted)

Change Summary: