Show a dialog if Plasma failed to create an OpenGL Context

Review Request #124576 - Created Aug. 1, 2015 and submitted

Information
David Edmundson
plasma-workspace
a37ec33...
Reviewers
plasma

Show a dialog if Plasma failed to create an OpenGL Context.

remove that "shutup" option we had, it was a workaround for an issue with Qt5.1 spewing warnings constantly.

Normal plasma is the same as before.
I don't know how to break my openGL, but placing a random qFatal() with the same error message got my dialog perfectly.

Issues

  • 0
  • 2
  • 2
  • 4
Description From Last Updated
Martin Klapetek
Martin Klapetek
David Edmundson
Review request changed

Status: Closed (submitted)

Change Summary:

Submitted with commit 727852897203fb750d9a06f04b78b07527573948 by David Edmundson to branch master.
Martin Flöser

Could you add a call to

QCoreApplication::setAttribute(Qt::AA_ForceRasterWidgets);

before showing the warning message - just to be sure that it doesn't try creating another GL context and dies on it.

  1. on it, thanks

Martin Klapetek

FYI, This may not entirely work as https://bugs.kde.org/show_bug.cgi?id=358869 shows

  1. ack, there's a new message that we're not catching.

    I don't know what the string is though.

  2. I was thinking we could maybe check the GL version ourselves at the very start?
    There's a glXQueryVersion function for it. That would effectively catch all these
    crashes on no GL..?

  3. you can find the new string in http://code.qt.io/cgit/qt/qtdeclarative.git/tree/src/quick/items/qquickwindow.cpp?h=v5.5.1#n2566

    But there seems to be a better way according to http://code.qt.io/cgit/qt/qtdeclarative.git/tree/src/quick/scenegraph/qsgrenderloop.cpp?h=v5.5.1#n233

    Apparently we can get a signal on the QQuickWindow.

  4. Worth looking into, definitely.

    Though I don't know if a version check will catch the nvidia problem. The library will return something valid till you try to actually make some ioctl call to the missing kernel module.

    With regards to version checking, Fedora have an interesting patch they do with openGL version checks. See https://bugs.kde.org/show_bug.cgi?id=357755

  5. @Martin
    OOoooh, that's way better. ++

Loading...