Show a dialog if Plasma failed to create an OpenGL Context
Review Request #124576 - Created Aug. 1, 2015 and submitted
Show a dialog if Plasma failed to create an OpenGL Context.
remove that "shutup" option we had, it was a workaround for an issue with Qt5.1 spewing warnings constantly.
Normal plasma is the same as before.
I don't know how to break my openGL, but placing a random qFatal() with the same error message got my dialog perfectly.
That's only half you
Should this be something like ".contans()"? Or is the message guaranteed to be always this?
Does everything actually goes to stderr or should qDebug go to stdout?
(I don't actually know but I always thought that's how it is)
"Deprecated, does nothing"? Deprecated usually still work, this won't anymore, so I'd add that note
Just now I've read the actual message, "Please confirm your drivers" has two issues - a) it should mention graphics driver (OpenGL may not be that connection that users would make) and b) "confirm" suggests there's a button which will continue with the launching, kinda like "This video contains violence, please confirm you are over 15 [I am, let me in] [I'm not]", but this is not the case. That said, I believe that "Please check that your graphics drivers are installed correctly" would read better to the users. Thinking a bit more about it (though for later patch), maybe it should also offer to log out or open Konsole? Because this way you're just left out with black screen, unable to do anything.
Status: Closed (submitted)
Submitted with commit 727852897203fb750d9a06f04b78b07527573948 by David Edmundson to branch master.
Could you add a call to
before showing the warning message - just to be sure that it doesn't try creating another GL context and dies on it.