WIP: Implement drag and drop support for icon widget

Review Request #124472 - Created July 26, 2015 and submitted

Information
Kai Uwe Broulik
plasma-workspace
master
Reviewers
plasma
bshah

Brings back the ability to drop files onto a icon widget and have the associated application open it. Dropping something onto a folder does not yet work because it should use the konq menu thingie (Copy/Move/Link) but I don't want yet another copy of that (there's one in the folderview containment).

It should probably check already on drag enter whether it's a viable drop target (eg. executable or folder), also do some coding style cleanups I thought I had already committed earlier.

Dragged Gwenview onto the desktop, an icon was created.
Dropped one picture onto it, Gwenview opened it.
Dropped two pictures onto, Gwenview showed both.

Issues

  • 0
  • 2
  • 0
  • 2
Description From Last Updated
Bhushan Shah
Kai Uwe Broulik
Bhushan Shah
Kai Uwe Broulik
Review request changed

Status: Closed (submitted)

Change Summary:

Submitted with commit 5f8051324985d9fb14bccfa0a4ecda9830aeb143 by Kai Uwe Broulik to branch master.
Emmanuel Pescosta

   
applets/icon/plugin/icon_p.cpp (Diff revision 2)
 
 

QUrl::fromUserInput(droppedUrl.toString(), QString() QUrl::AssumeLocalFile) maybe?

applets/icon/plugin/icon_p.cpp (Diff revision 2)
 
 

Make use of your stringUrl ;)

applets/icon/plugin/icon_p.cpp (Diff revision 2)
 
 

The drop urls thingie from Dolphin (without Arks dndextract service):

KIO::DropJob *job = KIO::drop(QDropEvent *, m_url);
KJobWidgets::setWindow(job, QWidget *);

Is this what you want? :)

And thanks for this nice feature :)

Loading...