Search Bar has been added for Marble Maps

Review Request #124327 - Created July 11, 2015 and submitted

Information
Gábor Péterffy
marble
124295, 124297
124346
Reviewers
marble

This patch adds a search bar to Marble Maps. Because the loading of the plugins not works on Android, the search function is not working.

On linux it works fine when the runner plugins are loaded. On Android the UI appears fine but not working with loaded plugins.

Files


Issues

  • 10
  • 15
  • 2
  • 27
Description From Last Updated
i'd rather have the icon (Image) set the size Dennis Nienhüser Dennis Nienhüser
Why should the search bar be a child of the MarbleItem - is there any reason? :) Torsten Rahn Torsten Rahn
I'd rather do: Item { Rectangle { id: background } } Torsten Rahn Torsten Rahn
The top level item in a QML file should have "id: root" for consistency and be a plain item (unless ... Torsten Rahn Torsten Rahn
I don't think we need z-values in here at all. Dennis Nienhüser Dennis Nienhüser
height should be searchButton.height However I'd really prefer anchors to width/height calculations. It's much easier to maintain. The effect you ... Dennis Nienhüser Dennis Nienhüser
I think using anchors+margins in inputField would be nicer and achieves the same result (see above) Dennis Nienhüser Dennis Nienhüser
Seems unused Dennis Nienhüser Dennis Nienhüser
also initialize m_placemarkModel to nullptr here Dennis Nienhüser Dennis Nienhüser
I'd delete m_searchManager before (just in case the method is called more than once) Dennis Nienhüser Dennis Nienhüser
Gábor Péterffy
Gábor Péterffy
Dennis Nienhüser
Gábor Péterffy
Dennis Nienhüser
Dennis Nienhüser
Torsten Rahn
Torsten Rahn
Torsten Rahn
Dennis Nienhüser
Gábor Péterffy
Torsten Rahn
Dennis Nienhüser
Gábor Péterffy
Review request changed

Status: Closed (submitted)

Change Summary:

Submitted with commit a19e608a2b3ad87ce5fe6c51b548459daf3ad7a1 by Mikhail Ivchenko on behalf of Gábor Péterffy to branch master.
Loading...