Add option to always show all system tray icons
Review Request #124234 - Created July 2, 2015 and submitted
|Kai Uwe Broulik|
This adds an option to always show all system tray icons and never collapse them into the popup. I've seen a couple of people already requesting this.
Enabled and disabled the option and tray icons along with the arrow came and went, started music player and media controller properly appeared and disappeared, started and quit KMail and its icon properla appeared and disappeared with both options.
I'd change the label to "Always show all entries" (actually, it would make sense to add "Always" to the combobox labels as well, but that's a different story). Other than that, it looks fine, and even though the same effect could be achieved by manually setting all entries to (Always) Shown, I think it's worth having it in there as a convenience feature for those who just don't like auto-hidding stuff.
- Rename option to "Always show all items"
- Refactor dialog to use QtLayouts so it can properly be resized (will split that into a separate commit)
- Dim passive items when all are shown, looks a bit muddy to me, though
Revision 2 (+128 -105)
Nice addition. I was checking if users are able to realize the setting - and it is obvious since the drop down is hidden. However the layout of the checkbox is not really nice. Add more space to the details below and indent the siblings. Maybe it's worth to think about an alternativ text to allow accordance with the configurability of the dropdowns. E.g. 'Personalized tray icons', and enable/checked means you can change the details below.
So what you get is a default checkbox that is checked by default and which controls the list (enable/disable) (which it already does I believe) and that demonstrates a knowing from the user perspective that grouping (or hiding) is a common phenomenon (in all of these systems) and you build on the prior knowledge of the user in any computer system and yadda yadda yadda why am I even saying these things you don't want it anyway ;-) bye. And writing on a smartphone is horrible just so you know.