Only export urls when monitor is running

Review Request #124162 - Created June 24, 2015 and submitted

Information
Pinak Ahuja
baloo
master
Reviewers
baloo
vhanda

Every monitor now, has to register with the extractor. The extractor keeps track of running monitors and only sends out the urlChanged signal if one or more monitors are running.

Tested using dbus-monitor, extractor only exports urls when monitor is running.

Issues

  • 2
  • 2
  • 1
  • 5
Description From Last Updated
You can use the following to solve this issue: namespace org { namespace kde { #include balloo_interface.h namespace baloo { ... Stefan Brüns Stefan Brüns
Sorry, the generated header does not like to be included from inside a namespace. The following works: #include "baloo_interface.h" #include ... Stefan Brüns Stefan Brüns
Pinak Ahuja
Stefan Brüns
Pinak Ahuja
Vishesh Handa
Stefan Brüns
Pinak Ahuja
Review request changed

Status: Closed (submitted)

Change Summary:

Submitted with commit 72ca7fe3234500ac5f33d67f9b205ab6a09dd854 by Pinak Ahuja to branch master.
Stefan Brüns

   

You can use the following to solve this issue:

namespace org {
  namespace kde {
    #include balloo_interface.h
    namespace baloo {
      #include extractor_interface.h
    }
  }
}

and add the -N flag to qdbusxml2cpp to avoid the automatic namespacing:
qdbusxml2cpp -c ExtractorInterface -N -p extractor_interface org.kde.balooExtractor.xml
qdbusxml2cpp -c BallooInterface -N -p baloo_interface org.kde.baloo.xml

The interfaces will be available as
org::kde::BalooInterface
org::kde::baloo::ExtractorInterface

Stefan Brüns

   

Sorry, the generated header does not like to be included from inside a namespace.

The following works:

#include "baloo_interface.h"
#include "extractor_interface.h"

namespace org {
  namespace kde {
    typedef ::OrgKdeBalooInterface BalooInterface;
    namespace baloo {
      typedef ::OrgKdeBalooExtractorInterface ExtractorInterface;
}}}

qdbusxml2cpp -N -p extractor_interface org.kde.balooExtractor.xml
qdbusxml2cpp -N -p baloo_interface org.kde.baloo.xml

  1. I was trying to avoid keeping manually generated proxy classes in the source tree (by generating them with cmake during build), but since these classes will be used at more than one place (GUI monitor, CLI monitor and some tests) keeping them in the source tree would make sense I guess. I'll do that and change the interface name in a separate patch as this one has already been submitted.

Loading...