Support overwrite prompt of unrar v5

Review Request #124111 - Created June 16, 2015 and submitted

Information
Ragnar Thomsen
ark
master
349131
Reviewers
kdeutils
elvisangelaccio, rkcosta

The overwrite prompt of unrar v5 changed compared to v3 and v4. This causes Ark to hang when extracting a rar archive with unrar v5 when a destination file exists. In unrar v5 the overwrite prompt looks like:

Would you like to replace the existing file file1.txt
    32 bytes, modified on 15-05-2015 14:26
with a new one
    32 bytes, modified on 15-05-2015 14:26

and in unrar v3 and v4:

file1.txt already exists. Overwrite it ?

Ark currently only supports the v3/v4 prompt. This patch adds support for the v5 prompt by defining a QStringList containing regexps for both prompts and iterating through the QStringList in CliInterface::checkForFileExistsMessage().

Extracting rar archives using both v4 and v5 unrar works as expected, also when destination exists. Extraction using clizip and cli7z also works as expected.

Issues

  • 0
  • 5
  • 2
  • 7
Description From Last Updated
Ragnar Thomsen
Raphael Kubo da Costa
Ragnar Thomsen
Ragnar Thomsen
Ragnar Thomsen
Raphael Kubo da Costa
Ragnar Thomsen
Elvis Angelaccio
Raphael Kubo da Costa
Ragnar Thomsen
Ragnar Thomsen
Review request changed

Status: Closed (submitted)

Change Summary:

Submitted with commit fba2a2201deaf0ec4407e2dc2fba61c2e1f4a088 by Ragnar Thomsen to branch Applications/15.08.
Loading...