Allow to cancel critical battery timer
Review Request #124037 - Created June 7, 2015 and submitted
|Kai Uwe Broulik|
|plasma, solid, usability|
To prevent David from eventually breaking his bones tumbling down the stairs rushing for his AC adapter, this adds a "Cancel" button to the battery critical notification that allows to cancel the timeout for automatic suspend/shutdown.
Got a "Cancel" button only when it was configured to do something, clicking the button from both popup and history cancelled the timeout. (Unfortunately the notification doesn't fit into the popup at all now)
I saw Vishesh running with the laptop in his hands here, so he's in danger of also running into this bone-breaking problem.
Perhaps we can avoid the repitition of the title in the maintext and make it fit better this way?
Status: Closed (submitted)
Submitted with commit 9bb399ef24a3323788ef3084f2e404c8831f251b by Kai Uwe Broulik to branch master.
Simple cancel without a countdown makes not much sense. Do I have bone-breaking 10sec or more? Or is it the small progressbar right hand? It would be good to have some text as well. By the way: ellipsis in this widget are not so good (guess the full text is shown in a tooltip). I'd recommend "Battery-low condition" as title plus sub text "remaining: 2%/~10min" and "shutdown in: 10s" with the option to cancel, if relevant.
Does the safety shutdown pops-up again or is it the user's duty now to care about saving stuff? I'm not sure if overriding safety features is a good idea in general.