[Ark] Improve hide/show logic for information panel

Review Request #123980 - Created June 1, 2015 and submitted

Information
Ragnar Thomsen
ark
frameworks
Reviewers
kdeutils
elvisangelaccio, rkcosta

The logic governing hiding/showing of the infopanel as well as storing/retrieving the size of the QSplitter was reworked into a more intuitive and simple approach. A configuration option "showInfoPanel" of type bool was added, which stores whether or not the infopanel should be shown. The option "splitterSizesWithBothWidgets" was removed, since it's no longer needed. Default values of "splitterSizes" are now set in the kcfg file, instead of in the C++ code.

Show/hide the information panel via the Settings menu works as expected. Ark remembers whether or not it was shown after closing/opening the program. The sizes of the splitter are also remembered after hiding/showing and after program restart. Deleting the splitterSizes line in ~/.config/arkrc and opening Ark results in the default sizes of 200/100 being used.

Issues

  • 1
  • 4
  • 0
  • 5
Description From Last Updated
Why not do this in saveSplitterSizes()? Raphael Kubo da Costa Raphael Kubo da Costa
Raphael Kubo da Costa
Ragnar Thomsen
Ragnar Thomsen
Ragnar Thomsen
Raphael Kubo da Costa
Ragnar Thomsen
Ragnar Thomsen
Raphael Kubo da Costa
Ragnar Thomsen
Raphael Kubo da Costa
Ragnar Thomsen
Review request changed

Status: Closed (submitted)

Change Summary:

Submitted with commit 7370acf337919f3a9a5dda7cda2680f8c1fc4139 by Ragnar Thomsen to branch frameworks.
Loading...